Skip to content

Commit

Permalink
main: list-images takes no args (just --filter)
Browse files Browse the repository at this point in the history
Tiny commit to error if extra arguments are passed to list-images.
Only `--filter` is supported there currently.
  • Loading branch information
mvo5 authored and ondrejbudai committed Dec 3, 2024
1 parent 99bd43e commit 6d978dd
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions cmd/image-builder/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ operating sytsems like centos and RHEL with easy customizations support.`,
Short: "List buildable images, use --filter to limit further",
RunE: cmdListImages,
SilenceUsage: true,
Args: cobra.NoArgs,
}
listImagesCmd.Flags().StringArray("filter", nil, `Filter distributions by a specific criteria (e.g. "type:rhel*")`)
listImagesCmd.Flags().String("output", "", "Output in a specific format (text, json)")
Expand Down
15 changes: 15 additions & 0 deletions cmd/image-builder/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,18 @@ func TestListImagesOverrideDatadir(t *testing.T) {
err := main.Run()
assert.EqualError(t, err, `no repositories found in the given paths: [/this/path/does/not/exist]`)
}

func TestListImagesErrorsOnExtraArgs(t *testing.T) {
restore := main.MockNewRepoRegistry(testrepos.New)
defer restore()

restore = main.MockOsArgs(append([]string{"list-images"}, "extra-arg"))
defer restore()

var fakeStdout bytes.Buffer
restore = main.MockOsStdout(&fakeStdout)
defer restore()

err := main.Run()
assert.EqualError(t, err, `unknown command "extra-arg" for "image-builder list-images"`)
}

0 comments on commit 6d978dd

Please sign in to comment.