Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Add Fedora 41 runners #138

Closed
wants to merge 1 commit into from
Closed

aws: Add Fedora 41 runners #138

wants to merge 1 commit into from

Conversation

bcl
Copy link
Contributor

@bcl bcl commented May 13, 2024

This needs to have the ami image references added. IIRC @ondrejbudai did that the last time I did this :)

@bcl bcl requested a review from ondrejbudai May 13, 2024 17:27
@jrusz
Copy link
Contributor

jrusz commented May 14, 2024

I found what I believe is the latest fedora-rawhide cloud image, copied it to our account, tagged it and filled it out here. Can you test them if they work @bcl ?

@bcl
Copy link
Contributor Author

bcl commented May 14, 2024

@jrusz I'm not sure how (or if) this can be tested. I'm going to need Fedora 41 (with dnf5 5.2.1.0 or later) for a followup to osbuild/osbuild#1776 when I turn the dnf5 depsolving back on for f41. So there's some moving parts involved...

@jrusz
Copy link
Contributor

jrusz commented May 14, 2024

@jrusz I'm not sure how (or if) this can be tested. I'm going to need Fedora 41 (with dnf5 5.2.1.0 or later) for a followup to osbuild/osbuild#1776 when I turn the dnf5 depsolving back on for f41. So there's some moving parts involved...

Oh ok, I thought you knew since you created a branch here instead of a fork. So you just take the commit SHA which is 0e7d5265f19ac45c39a1f3408862a7ec6722c9e4 in this case and replace the one in schutzbot/terraform in the target repo https://github.com/osbuild/osbuild/blob/main/schutzbot/terraform and then try to add the runners in the .gitlab-ci.yml file in all the places you need just like fedora-40 here but fedora-41 instead https://github.com/osbuild/osbuild/blob/main/.gitlab-ci.yml#L44 .

@croissanne
Copy link
Member

let's add f41 via the refresh bot #164

@bcl
Copy link
Contributor Author

bcl commented Jul 22, 2024

let's add f41 via the refresh bot #164

ok, what's the refresh bot? Should I just close this?

@croissanne
Copy link
Member

let's add f41 via the refresh bot #164

ok, what's the refresh bot? Should I just close this?

yup! It's a bot that creates PRs like https://github.com/osbuild/gitlab-ci-terraform/pulls?q=is%3Apr+is%3Aclosed+image+refresh, it does need a placeholder first otherwise it won't recognize that it's an actual image.

@croissanne
Copy link
Member

#165

@achilleas-k
Copy link
Member

Close this?

@thozza thozza closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants