Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test symbols rather than strings for OS detection #28

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

geoffp
Copy link
Contributor

@geoffp geoffp commented Nov 20, 2023

This fixes #27 for me. Just tests for symbols rather than strings.

@orzechowskid
Copy link
Owner

thanks for this! I don't have a Mac to test with so I've been depending on others to help out 😬

it looks like github actions are failing due to unrelated issues (nodejs/node-gyp#2869 , if I'm reading the logs correctly) so it might be a bit before I can get an official release out but this change looks good. thanks again!

@orzechowskid orzechowskid merged commit 0ce23b2 into orzechowskid:main Nov 21, 2023
1 of 3 checks passed
@geoffp
Copy link
Contributor Author

geoffp commented Nov 21, 2023

@orzechowskid Happy to help! I suuuper want this to work, and I'm happy to help however I can. I have Mac OS and FreeBSD on my desktop right now, so I can test stuff on weird OSes; feel free to reach out if you need something.

I actually still have not been able to get highlighting to work in a tsx-ts-mode or typescript-ts-mode buffer, despite this fix, so the journey continues. But that's another issue! Any tips on debugging process are greatly appreciated. I'm still an elisp novice.

@geoffp geoffp deleted the fix-shared-lib-mac-x86-64 branch November 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(css-in-js-mode-fetch-shared-library) installs Linux binaries on Mac OS / x86_64
2 participants