Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load session only once when middleware is used #4187

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Nov 4, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (ca0d6a7) to head (83ded88).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
session/manager_http.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4187   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         380      380           
  Lines       27107    27114    +7     
=======================================
+ Hits        21297    21303    +6     
- Misses       4194     4195    +1     
  Partials     1616     1616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 234b6f2 into master Nov 4, 2024
29 checks passed
@aeneasr aeneasr deleted the remove-superfluous-session-fetch branch November 4, 2024 14:09
@aeneasr aeneasr restored the remove-superfluous-session-fetch branch November 5, 2024 18:24
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant