Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extra go migrations in persister #4183

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Oct 30, 2024

No description provided.

@alnr alnr self-assigned this Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (53874c1) to head (2110e48).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
driver/registry.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4183   +/-   ##
=======================================
  Coverage   78.57%   78.58%           
=======================================
  Files         380      380           
  Lines       27114    27117    +3     
=======================================
+ Hits        21306    21310    +4     
- Misses       4190     4191    +1     
+ Partials     1618     1616    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense though to just add a different migration type that is sql files that just don't run in a transaction? The go migrations are quite painful to write IMO. But it's good enough.

@aeneasr aeneasr merged commit 7bec935 into master Oct 30, 2024
29 of 31 checks passed
@aeneasr aeneasr deleted the alnr/extra-go-migrations branch October 30, 2024 13:09
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
malosayli pushed a commit to nayla-finance/kratos that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants