Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return a specific error message for email & phone validation errors #4166

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Oct 22, 2024

Related issue(s)

Fixes #4192

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Oct 22, 2024
@jonas-jonas
Copy link
Member Author

This does not pass the tests, because somewhere along the chain we now escape \\ twice, which breaks one test. I am not sure how to fix, yet.

Not equal:
	expected: "\\ is not a valid email address"
	actual  : "\\\\ is not a valid email address"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email validation message is not translatable
1 participant