Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass on correct context during verification #4151

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

zepatrik
Copy link
Member

@zepatrik zepatrik commented Oct 9, 2024

Spans in tracing are not correctly nested because of this.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 53.65854% with 19 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (2f8aaee) to head (6b0d7e9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/strategy/code/strategy_verification.go 55.55% 7 Missing and 9 partials ⚠️
selfservice/strategy/link/strategy_verification.go 40.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4151      +/-   ##
==========================================
- Coverage   78.59%   78.56%   -0.03%     
==========================================
  Files         379      379              
  Lines       26988    27031      +43     
==========================================
+ Hits        21210    21237      +27     
- Misses       4166     4181      +15     
- Partials     1612     1613       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zepatrik zepatrik merged commit 7e0b500 into master Oct 9, 2024
29 of 31 checks passed
@zepatrik zepatrik deleted the fix/verification-tracing-ctx branch October 9, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants