Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: override parameters #4140

Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: override parameters #4140

merged 1 commit into from
Oct 3, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Oct 3, 2024

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (ad1acd5) to head (35ec07f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
persistence/sql/identity/persister_identity.go 83.33% 2 Missing and 2 partials ⚠️
identity/pool.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4140      +/-   ##
==========================================
- Coverage   78.60%   78.60%   -0.01%     
==========================================
  Files         377      378       +1     
  Lines       26914    26935      +21     
==========================================
+ Hits        21156    21172      +16     
- Misses       4148     4150       +2     
- Partials     1610     1613       +3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 629d867 into master Oct 3, 2024
30 of 31 checks passed
@aeneasr aeneasr deleted the faster-listing-mr branch October 3, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant