Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: login failed webhook #4101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: login failed webhook #4101

wants to merge 3 commits into from

Conversation

barnarddt
Copy link

Add a webhook to fire after a login attempt has failed

Related issue(s)

#3580

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! While the implementation demonstrates solid effort, it has limitations: (a) it only addresses login scenarios, and (b) it does not handle all error cases.

We recently added tracing events that include failures, such as "login failed." Using these events to notify external systems would be more suitable than introducing an additional webhook. Webhooks are intended to modify, extend, or alter business logic within a specific flow (e.g., adjusting user data or blocking logins).

Tracing events also enable tracking incomplete logins, providing more comprehensive insights.

Given these considerations, we are unlikely to merge this PR despite the quality of the work. Thank you for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants