Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 400 bad request for invalid login challenge #3404

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jul 31, 2023

No description provided.

@hperl hperl self-assigned this Jul 31, 2023
@hperl hperl changed the title feat: return bad request for invalid login challenge fix: return 400 bad request for invalid login challenge Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #3404 (a03a36f) into master (e3fcf0c) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 25.00%.

❗ Current head a03a36f differs from pull request most recent head d546bad. Consider uploading reports for the commit d546bad to get more accurate results

@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   78.02%   78.02%           
=======================================
  Files         327      327           
  Lines       21364    21369    +5     
=======================================
+ Hits        16669    16674    +5     
- Misses       3457     3458    +1     
+ Partials     1238     1237    -1     
Files Changed Coverage Δ
hydra/hydra.go 62.96% <0.00%> (-4.15%) ⬇️
hydra/fake.go 80.00% <100.00%> (+10.00%) ⬆️
selfservice/flow/login/handler.go 80.70% <100.00%> (+1.31%) ⬆️

@hperl hperl merged commit ca34e9b into master Jul 31, 2023
29 checks passed
@hperl hperl deleted the hperl/fix/login-challenge-500-error branch July 31, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants