-
-
Notifications
You must be signed in to change notification settings - Fork 964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple origins in webauthn config #3380
Conversation
0e268fa
to
4c36858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, how will this affect current Webauthn credentials?
4c36858
to
fd90a5d
Compare
That took longer than expected, because the webauthn library silently broke contract by switching the encoding from base64 to base64urlencoded. |
Codecov Report
@@ Coverage Diff @@
## master #3380 +/- ##
==========================================
+ Coverage 78.02% 78.03% +0.01%
==========================================
Files 327 327
Lines 21364 21368 +4
==========================================
+ Hits 16669 16675 +6
+ Misses 3457 3456 -1
+ Partials 1238 1237 -1
|
fd90a5d
to
380a03b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f6ef345
to
592676b
Compare
Docs PR: ory/docs#1474 |
f7a47f0
to
c0a5a0c
Compare
c0a5a0c
to
647fb49
Compare
Users can now supply a list of origins for webauthn in the configuration.
647fb49
to
d8defe5
Compare
Related issue(s)
ory/docs#1474
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments