Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for expired challenges return HTTP 410 and redirect url #3802

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

terev
Copy link
Contributor

@terev terev commented Jul 21, 2024

Return HTTP 410 and initial auth url for consent app to redirect user agent to when an expired challenge is supplied. This implements the same mechanism provided for consent apps to handle previously utilized challenges #2473 .

BREAKING CHANGES: This patch changes the response status code for expired challenges from 401 to 410. It also changes the schema of the response from fosite.RFC6749Error to flow.OAuth2RedirectTo.

Related issue(s)

Closes #3772

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@terev terev requested review from aeneasr, hperl and alnr as code owners July 21, 2024 18:32
@terev terev changed the title feat: return HTTP 410 and initial auth url for consent app to redirect user agent feat: for expired challenges return HTTP 410 and redirect url Jul 24, 2024
…t the user agent to when an expired challenge is supplied
@terev terev force-pushed the expired-challenge-redir branch from 4441c17 to 783d954 Compare July 25, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expired Login/Consent Challenge Should be Resolvable for Consent App
1 participant