fix: change min max and regex to not reuse a const

[sirtimbly]

Status

READY

Description

Fixes #819

Related PRs

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

[anymaniax]

is this pull request still relevant? If you want to remove the consts maybe we can add a config for it?

[melloware]

There is a merge conflict

[sirtimbly]

I'm sorry I forgot about this PR. I still think this is the correct choice, using consts for simple literal values isn't going to improve perf in a meaningful way, and it's easier to use literals than to write logic that properly created different consts for different min/max values.

Anyway, it's rebased.

[melloware]

@sirtimbly did you see AnyMananiax comment "Just pushed a fix" in April? Have you tried 6.19.1 and do you still get the same errors you were getting before?

[melloware]

also @sirtimbly can you check out this issue with Zod and two dimensional array? #1027

[sirtimbly]

@sirtimbly did you see AnyMananiax comment "Just pushed a fix" in April? Have you tried 6.19.1 and do you still get the same errors you were getting before?

Tested, it seems to be fixed because the name calculation is more complete.