Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hono): custom validator always does return value #1813

Merged

Conversation

soartec-lab
Copy link
Member

@soartec-lab soartec-lab commented Jan 13, 2025

Status

READY

Description

This is to avoid the following lint error:

error TS7030: Not all code paths return a value.

And update sample apps.

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

export default defineConfig({
  petstoreSplitHandlers: {
    input: '../specifications/petstore.yaml',
    output: {
      target: '../generated/hono/petstore-split-handlers/endpoints.ts',
      schemas: '../generated/hono/petstore-split-handlers/handlers/schemas',
      mode: 'split',
      client: 'hono',
      override: {
        hono: {
          handlers: '../generated/hono/petstore-split-handlers/handlers',
        },
      },
    },
  },
}

@soartec-lab soartec-lab added bug Something isn't working hono Hono related issue labels Jan 13, 2025
This is to avoid the following lint error:

```
error TS7030: Not all code paths return a value.
```
@soartec-lab soartec-lab force-pushed the fix/hono/suppress-eslint-warnings branch from 6ee38f5 to 697e9d3 Compare January 15, 2025 00:12
@soartec-lab soartec-lab marked this pull request as ready for review January 15, 2025 00:12
@soartec-lab soartec-lab requested a review from anymaniax January 15, 2025 00:12
@soartec-lab soartec-lab merged commit 828f558 into orval-labs:master Jan 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hono Hono related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants