Fix chaotic shuffle of generated types #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that the sort is not necessary (you can use types before defining them in Typescript), and that it has never properly worked, I think that we should get rid of it. This will lead to the items being sorted in the same order than in the OpenApi file, which looks like a good solution to me. |
melloware
approved these changes
Jan 10, 2025
|
LGTM cc @AllieJonsson ? |
Seems logical! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Fix #1382
WIP
Description
Sometimes, when generating Orval schema, some generated types are moved around the file. This PR fixes it.
Related to issue Types in generated react-query schema have unstable order, causing noisy diffs #1382
Related PRs
No related PRs
Todos
Steps to Test or Reproduce
Outline the steps to test or reproduce the PR here.