fix(zod): pass resolved specKey in context #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FEgor04
force-pushed
the
import-from-subdirectory
branch
2 times, most recently
from
386b28d to
472d111
Compare
FEgor04
changed the title
FEgor04
force-pushed
the
import-from-subdirectory
branch
from
472d111 to
37c9f50
Compare
Add a new file to `import-from-subdirectory/subdirectory`, reference this file in `petstore.yaml`. Codegen for this schema works for at least React Query, but for zod it throws an error: ``` 🛑 importFromSubdirectory - Oops... 🍻. Ref not found: another-file.yaml#/components/schemas/AnotherSchema ```
FEgor04
force-pushed
the
import-from-subdirectory
branch
from
37c9f50 to
8362f08
Compare
melloware
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR adds a new entry to
tests/configs/zod.config.tsthat shows a bug for$refobjects and fixes itIf we reference a schema in subdirectory, it works at least for React Query and Fetch, however it fails for Zod.
UPD: The solution to the bug is to get specKey key from resolved schema and use it to resolve its fields