-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): filters = {} treated as undefined #1740
Conversation
I hope you don't mind a random person chiming in on this pull request, but I wanted to mention something I discovered today in debugging a regression between 7.2.0 and 7.3.0 on my own code base. The commit that introduced the new 'exclude' and 'include' functionality for filters (#1690) changed the logic that gets applied in the |
Oh nice. I don't mind at all. Did you want to submit a PR? |
I’ll wait for this discussion for a short time 👀 |
I could certainly open a PR if you would like, but if you would like to take care of it yourself that works for me! I'm not exactly sure what coding style is typically employed on your codebase (the debugging I was doing on my end was the as-built npm package 'dist' files, so they were esbuild-ified). I think I would simply change the if check to |
@redsky17 that sounds right feel free to submit a PR I think your fix is the right one. |
I have opened #1744. Thanks folks! |
Fix #1736 fix(core): filters = {} treated as undefined