feat: TData generic for mutation hooks #1735
Merged
+18
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing? |
|
Seems good but it's a breaking change. I don't think it's will break for a lot of people and case. I am gonna do deeper check in the following the days |
anymaniax
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
it's good for me but it's still a little breaking change for some people. What do you think @melloware @soartec-lab
|
@anymaniax |
soartec-lab
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Right now we have an opportunity to override the type of
datathat is returned by the generateduseQueryhooks usingTDatageneric. It would be great to have the same opportunity with theuseMutationhooks.Todos
Steps to Test or Reproduce
You can use samples tests