Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): apply w3c WAI-ARIA (a11y) pattern #1143

Merged
merged 16 commits into from
Jan 31, 2025
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Dec 6, 2024

Fixes #1115

Proposed Changes

  • Move some functionality from the Autocomplete component to the Dropdown component
  • Specifiy Dropdown as menu role when not selectable
  • Implement w3c WAI-ARIA (a11y) Combobox pattern in Dropdown component when selectable
    • Update aria and role attributes
    • Update keybinds
    • Add selectable prop to specify behaviour
  • Update dropdown dependent Autocomplete, Taginput, Datepicker, TimePicker component
  • Updated documentation

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Dec 6, 2024
Copy link

netlify bot commented Dec 6, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 44c5aab
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/679cc823c84563000825f406
😎 Deploy Preview https://deploy-preview-1143--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek added the a11y Accessibility label Dec 6, 2024
@mlmoravek mlmoravek changed the title feat(dropdown): add a11y features feat(dropdown): apply w3c WAI-ARIA (a11y) "combobox" pattern Dec 9, 2024
@mlmoravek mlmoravek marked this pull request as ready for review December 9, 2024 15:45
@mlmoravek mlmoravek changed the title feat(dropdown): apply w3c WAI-ARIA (a11y) "combobox" pattern feat(dropdown): apply w3c WAI-ARIA (a11y) pattern Jan 31, 2025
@mlmoravek mlmoravek merged commit b1db037 into develop Jan 31, 2025
10 of 11 checks passed
@mlmoravek mlmoravek deleted the dropdown/combobox branch January 31, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y Dropdown keyboard issue
1 participant