Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): set fixed tab and tabpanel values for native role attribute #1119

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Nov 18, 2024

Part of #1127

Proposed Changes

  • remove wrong role value for tab
  • remove ariaRole prop from TabItem
  • set fixes tab and tabpanel role attributes

@mlmoravek mlmoravek added the a11y Accessibility label Nov 18, 2024
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 6f9d574
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/67497f7cde42290008aa6b73
😎 Deploy Preview https://deploy-preview-1119--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Nov 18, 2024
@mlmoravek mlmoravek changed the title fix(tabs): set fixed role values tab and tabpanel fix(tabs): set fixed tab and tabpanel values for native role attribute Nov 18, 2024
@mlmoravek mlmoravek merged commit c1afcf3 into develop Nov 29, 2024
10 checks passed
@mlmoravek mlmoravek deleted the bug/tabs/aria-role branch November 29, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant