Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

windows support #242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions pkg/jackal/jackal.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"context"
"flag"
"fmt"
"github.com/ortuman/jackal/pkg/util/rlimit"
"io"
"math/rand"
"os"
Expand Down Expand Up @@ -57,8 +58,6 @@ import (
)

const (
darwinOpenMax = 10240

defaultBootstrapTimeout = time.Minute
defaultShutdownTimeout = time.Second * 30

Expand Down Expand Up @@ -202,7 +201,7 @@ func (j *Jackal) Run() error {
grpc_prometheus.EnableHandlingTimeHistogram()

// set maximum opened files limit
if err := setRLimit(); err != nil {
if err := rlimit.SetRLimit(); err != nil {
return err
}

Expand Down Expand Up @@ -523,23 +522,3 @@ func (j *Jackal) waitForStopSignal() os.Signal {
signal.Notify(j.waitStopCh, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM)
return <-j.waitStopCh
}

func setRLimit() error {
var rLim syscall.Rlimit
if err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &rLim); err != nil {
return err
}
if rLim.Cur < rLim.Max {
switch runtime.GOOS {
case "darwin":
// The max file limit is 10240, even though
// the max returned by Getrlimit is 1<<63-1.
// This is OPEN_MAX in sys/syslimits.h.
rLim.Cur = darwinOpenMax
default:
rLim.Cur = rLim.Max
}
return syscall.Setrlimit(syscall.RLIMIT_NOFILE, &rLim)
}
return nil
}
27 changes: 27 additions & 0 deletions pkg/util/rlimit/rlimit_unix.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
//go:build !windows

package rlimit

import "runtime"

const darwinOpenMax = 10240

func SetRLimit() error {
var rLim syscall.Rlimit
if err := syscall.Getrlimit(syscall.RLIMIT_NOFILE, &rLim); err != nil {
return err
}
if rLim.Cur < rLim.Max {
switch runtime.GOOS {
case "darwin":
// The max file limit is 10240, even though
// the max returned by Getrlimit is 1<<63-1.
// This is OPEN_MAX in sys/syslimits.h.
rLim.Cur = darwinOpenMax
default:
rLim.Cur = rLim.Max
}
return syscall.Setrlimit(syscall.RLIMIT_NOFILE, &rLim)
}
return nil
}
7 changes: 7 additions & 0 deletions pkg/util/rlimit/rlimit_windows.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//go:build windows

package rlimit

func SetRLimit() error {
return nil
}