Fix cmake and linking errors for CMake 3.3 and above #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerj
force-pushed
the
master-fix-linker-error-cmake-3.5
branch
from
0157afa
to
f3a9ed5
Compare
Link libraries by full path even in implicit directories: https://cmake.org/cmake/help/v3.5/policy/CMP0060.html This fixes a linker error with CMake 3.5, which as a result of target_link_libraries(orocos-rtt-${OROCOS_TARGET}_dynamic /full/path/to/liblog4cpp.so) adds -llog4cpp to the linker command line, which results in a linker error: /usr/bin/ld: cannot find -llog4cpp Not sure why the install-space is considered as an implicit link directory by CMake. Signed-off-by: Johannes Meyer <[email protected]>
meyerj
force-pushed
the
master-fix-linker-error-cmake-3.5
branch
from
f3a9ed5
to
9cff84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a linker error with CMake 3.5.1, which as a result of
adds
to the linker command line because the library path is considered as an implicit link directory.
It is not, and that's why the linker fails to find log4cpp on my Xenial system:
Not sure why the catkin install-space inside the home directory is considered as an implicit link directory by CMake 3.5.1. Might be a bug.
Solution:
NEW, if available. This will make sure that CMake adds the full path toliblog4cpp.soto the linker command line. It is basically a follow-up of CMP0003 for implicit link directories, which we set toNEWsince 8f6d7ff.