Skip to content

Commit

Permalink
Callbacks are marked as either later or immediatelly invoked
Browse files Browse the repository at this point in the history
  • Loading branch information
mabar committed Jun 19, 2024
1 parent 815cda6 commit 5308f84
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Orm/Filter/FindFilter.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ public function raw(array $condition): void

/**
* @param Closure(FindFilter): void $conditions
* @param-immediately-invoked-callable $conditions
*/
public function and(Closure $conditions): void
{
Expand All @@ -106,6 +107,7 @@ public function and(Closure $conditions): void

/**
* @param Closure(FindFilter): void $conditions
* @param-immediately-invoked-callable $conditions
*/
public function or(Closure $conditions): void
{
Expand All @@ -114,6 +116,7 @@ public function or(Closure $conditions): void

/**
* @param Closure(FindFilter): void $conditions
* @param-immediately-invoked-callable $conditions
*/
private function logicalOperator(Closure $conditions, string $operator): void
{
Expand Down
4 changes: 4 additions & 0 deletions src/UI/DataGrid/DataGrid.php
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ final class DataGrid extends BaseControl

/**
* @param Closure(SearchParameters): array<mixed> $dataSource
* @param-later-invoked-callable $dataSource
*/
public function __construct(protected string $rowPrimaryKey, protected Closure $dataSource)
{
Expand Down Expand Up @@ -107,6 +108,7 @@ public function setFilterFormFactory(Closure|null $filterFormFactory): void

/**
* @param Closure(array<(int|string)>, $this): void $action
* @param-later-invoked-callable $action
*/
public function addGlobalAction(string $name, string $label, Closure $action): void
{
Expand All @@ -115,6 +117,7 @@ public function addGlobalAction(string $name, string $label, Closure $action): v

/**
* @phpstan-param Closure(SearchParameters): (int|null) $itemsCountCallback

Check failure on line 119 in src/UI/DataGrid/DataGrid.php

View workflow job for this annotation

GitHub Actions / Coding standard (ubuntu-latest, 8.1)

Incorrect order of annotations in group.
* @param-later-invoked-callable $itemsCountCallback
*/
public function setPagination(Closure $itemsCountCallback): void
{
Expand Down Expand Up @@ -221,6 +224,7 @@ private function createParameters(): SearchParameters

/**
* @param Closure(SearchParameters): (int|null) $paginatorItemsCountCallback
* @param-immediately-invoked-callable $itemsCountCallback
*/
private function configurePage(
Paginator $paginator,
Expand Down

0 comments on commit 5308f84

Please sign in to comment.