This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Precompilation and line endings in YTemplater #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2014 15:38
|
Updated the code example message to be more informative. |
| templateFn; | ||
|
|
||
| if (engineInfo.className === 'Y.Handlebars') { | ||
| templateFn = templater.revive(evalTemplateFunctionString(templateData.precompiled), templater.engine); |
There was a problem hiding this comment.
Adding templater.engine as the second argument doesn't make sense to me. Could you please explain?
There was a problem hiding this comment.
The unit test failing was when running it under the Y.Handlebars engine.
In Y.Handlebars, the templater.revive method is overridden by the function template, were the environment variable is used to call methods like:
- env.VM.checkRevision
- env.VM.invokePartial
- env.compile
All those methods are existing within the engine object itself, hence me passing it as parameter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added information about how YTemplater makes use of line endings when precompiling template files.
This will help people to understand how YTemplater works and hopefully get ride of issues like the one described in #6.