Actually run the distributed tx expiry task #10297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timw
force-pushed
the
transaction_timer_expiry
branch
from
9e855e4 to
79d16df
Compare
tglman
reviewed
Sep 4, 2024
| @@ -651,6 +654,9 @@ public void run() { | |||
| checkTxTimeout(); | |||
| } | |||
| }; | |||
| final long timeout = OGlobalConfiguration.DISTRIBUTED_TX_EXPIRE_TIMEOUT.getValueAsLong(); | |||
| timer = new Timer("Distributed database tx expiry", true); | |||
| timer.scheduleAtFixedRate(txTimeoutTask, timeout / 3, timeout / 3); | |||
There was a problem hiding this comment.
We do have actually a global timer in the context so context.schedule should do, just to keep on check the number of threads running.
Probably is also better to execute the operation in the context thread pool, so do ~ context.execute(() -> checkTxTimeout()) because the timer is shared is better that the timer do just timing, I can add this myself later
(and did we really missed that? 🤦 )
timw
force-pushed
the
transaction_timer_expiry
branch
from
79d16df to
f9cd3bd
Compare
|
Perfect, Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Actually create a timer and schedule the distributed transaction timeout task.
The
com.orientechnologies.orient.server.distributed.impl.ODistributedDatabaseImpl#startTxTimeoutTimerTaskmethod creates the timeout task, but never schedules it on a Timer.Motivation
During heap dump analysis we observed some transactions remaining in the tracking list forever.
Related issues
Additional Notes
Checklist
[x] I have run the build using
mvn clean packagecommand[] My unit tests cover both failure and success scenarios