Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging Improvements #39

Merged
merged 3 commits into from
Apr 28, 2024
Merged

Debugging Improvements #39

merged 3 commits into from
Apr 28, 2024

Conversation

newsch
Copy link
Collaborator

@newsch newsch commented Jan 24, 2024 •
edited
Loading

  • Add check-html command to bulk-analyze html files
  • Add option to write matched, erroring, or panicing json to stdout
  • decide on parseable structured logging format, json or logfmt?

biodranik
biodranik approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newsch
Copy link
Collaborator Author

newsch commented Mar 14, 2024

@biodranik do you care what format the logs are in?
Something like logfmt would be more readable than JSON but also more parseable for when I'm analyzing the logs than tracing's default. That way we can keep it simple without having multiple levels/formats/outputs or detection logic.

@biodranik
Copy link
Member

I'm ok to try it )

@biodranik
Copy link
Member

@newsch should these changes be merged?

newsch added 3 commits April 28, 2024 12:50
@newsch
Add option to dump input json to stdout
677b79c 
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
@newsch
Use tracing-logfmt
9621eee 
Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
@newsch
Make parse functions collection-agnostic
f5f7df4 
This makes it possible to use a Set in one place and a Vec in another,
to log or count items without allocating a collection for all of them,
and to ignore errors with no overhead.

The alternative is converting them to custom iterators, which is more work
than I want to do right now.

Signed-off-by: Evan Lloyd New-Schmidt <[email protected]>
@newsch newsch marked this pull request as ready for review April 28, 2024 18:19
@newsch newsch merged commit e61f12d into main Apr 28, 2024
1 check passed
@newsch newsch deleted the debugging branch April 28, 2024 18:20
@newsch
Copy link
Collaborator Author

newsch commented Apr 28, 2024

@biodranik no need to rerun in production with this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biodranik biodranik biodranik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newsch @biodranik