Adds responsive component learn part 2 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for orcahome ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
evanjscallan
approved these changes
Apr 13, 2022
|
UI check for responsiveness passes. |
UXBrendan
requested review from
paulcretu
and removed request for
evanjscallan
|
We are going to deploy all passed PRs this Tuesday. Would it be possible for you to pass this PR so it's ready for our deployment session on Tuesday, Oct. 17? |
|
@UXBrendan I don't have the rights to pass the PR. The repository was setup in a way that someone has to review first as a flag then on review, the checks can be passed. |
| <div className={learnStyles.imageWrapper}> | ||
| <section aria-labelledby="salish" className={learnStyles.salishSection}> | ||
| <h1 id="salish" className={learnStyles.salishHeading}> | ||
| {' '} |
There was a problem hiding this comment.
Is this preceding space necessary in the H1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates code to match Figma design of issue#42 and makes section responsive