[WIP] Add Learn Page3 #83
Conversation
|
✅ Deploy Preview for orcahome ready! 🔨 Explore the source changes: c8e1f4a 🔍 Inspect the deploy log: https://app.netlify.com/sites/orcahome/deploys/62381c1c198e730008e6c668 😎 Browse the preview: https://deploy-preview-83--orcahome.netlify.app |
|
@paulcretu Please help reviewing my code to see if I did the good practice of code style, so I can keep moving on. Thank you! |
| <Container> | ||
| <Intro> | ||
| <ActionButton link="" text="Sounds of the Salish Sea" /> | ||
| <ActionButton link="" text="3 common calls" /> | ||
| <ActionButton | ||
| link="" | ||
| text="Souther Resident Killer Whale Call Catalog" | ||
| /> | ||
| <ActionButton link="" text="Exhibits" /> | ||
| </Intro> | ||
|
|
||
| <h1> Sounds Of The Salish Sea</h1> | ||
| <p> | ||
| Explore common sounds of the Salish Sea by selecting the animals and | ||
| other objects in this <br /> | ||
| panoramic soundscape of the inland waters of Washington State (USA) | ||
| and British Columbia <br /> | ||
| (Canada). | ||
| </p> |
There was a problem hiding this comment.
These changes are looking good, but this section of the page is covered under a separate issue. So try not to make changes related to another issue. It can be hard to review and can also create merge conflicts later.
There was a problem hiding this comment.
Oh, I see, at first I didn't notice that's a total different page. I will use other branches data to change it back
There was a problem hiding this comment.
What's the status of this? The changes look to still be present.
|
UI checks pass. |
|
We are going to deploy all passed PRs this Tuesday. Would it be possible for you to pass this PR so it's ready for our deployment session on Tuesday, Oct. 17? |
| <Container> | ||
| <Intro> | ||
| <ActionButton link="" text="Sounds of the Salish Sea" /> | ||
| <ActionButton link="" text="3 common calls" /> | ||
| <ActionButton | ||
| link="" | ||
| text="Souther Resident Killer Whale Call Catalog" | ||
| /> | ||
| <ActionButton link="" text="Exhibits" /> | ||
| </Intro> | ||
|
|
||
| <h1> Sounds Of The Salish Sea</h1> | ||
| <p> | ||
| Explore common sounds of the Salish Sea by selecting the animals and | ||
| other objects in this <br /> | ||
| panoramic soundscape of the inland waters of Washington State (USA) | ||
| and British Columbia <br /> | ||
| (Canada). | ||
| </p> |
There was a problem hiding this comment.
What's the status of this? The changes look to still be present.
| src={salishsea} | ||
| alt="Sounds Of The Salish Sea" | ||
| width={800} | ||
| height={450} | ||
| width={1234} |
There was a problem hiding this comment.
1234 seems random, is this the desired value?
| width={800} | ||
| height={450} | ||
| width={1234} | ||
| height={701} |
Problem
Fixes #43
Preview Result
Desktop:
Mobile
Because the Figma design is a little bit tricky for me, I managed to design the look, but I am not sure if my code right now is following the best practice, so I am gonna need some suggestions here!