Add the last part of test #17 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are already an error on the test extended operator.
there always are an error for the last test with the add in JaxBContainer.
impossible create new operator PropertyExistType with the filter23.xsd.
change the name of the test file OGC_TestFilterEncoding to OGC_FilterEncodingTest.
SPalominos
suggested changes
May 15, 2017
|
|
||
| //test Disjoint | ||
| xml = OGC_TestFilterEncoding.class.getResourceAsStream("filter_Disjoint.xml"); | ||
| xml = OGC_FilterEncodingTest.class.getResourceAsStream("filter_Disjoint.xml"); |
There was a problem hiding this comment.
The travis check fails because the resource file filter_Disjoint.xml is called Filter_Disjoint.xml with an upper case F
Add modification for the last test. orbisgis#17 there always an error with the test : new Operator.
SPalominos
suggested changes
May 16, 2017
There was a problem hiding this comment.
- You have some problem with character because of the file encoding (ISO to UTF).
- Is it necessary to have the package name
net.opengis.fes._2_0_2.newOps? Can we use instead something likeorg.orbisgis.ogccustomjaxb.newOps? - Please, set the header of the file like in the other OrbisGIS files.
|
All the file are encoded in UTF-8 on IntelliJ and I have change the character with probleme for the next commit. |
change pakage name, add header in test file and change character with probleme in javadoc.
Add header in java classes.
ebocher
approved these changes
May 17, 2017
| // Ce fichier a �t� g�n�r� par l'impl�mentation de r�f�rence JavaTM Architecture for XML Binding (JAXB), v2.2.8-b130911.1802 | ||
| // Voir <a href="http://java.sun.com/xml/jaxb">http://java.sun.com/xml/jaxb</a> | ||
| // Toute modification apport�e � ce fichier sera perdue lors de la recompilation du sch�ma source. | ||
| // G�n�r� le : 2017.05.15 � 03:12:35 PM CEST |
| // Voir <a href="http://java.sun.com/xml/jaxb">http://java.sun.com/xml/jaxb</a> | ||
| // Toute modification apport�e � ce fichier sera perdue lors de la recompilation du sch�ma source. | ||
| // G�n�r� le : 2017.05.15 � 03:12:35 PM CEST | ||
| // Ce fichier a été généré par l'implémentation de référence JavaTM Architecture for XML Binding (JAXB), v2.2.8-b130911.1802 |
There was a problem hiding this comment.
This class has been generated by jaxb and there are a part of the javadoc which is in french.
| @@ -59,7 +59,7 @@ public String getValueReference() { | |||
| } | |||
|
|
|||
| /** | |||
| * D�finit la valeur de la propri�t� valueReference. | |||
| * Définit la valeur de la propriété valueReference. | |||
There was a problem hiding this comment.
All javadoc , text (header) must be in English.
SPalominos
approved these changes
May 18, 2017
change some lines of javadoc from propertyExistsType which are in french.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the last part of the test. #17