Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: smoke and sanity integration tests are failing. #2501

Merged
merged 37 commits into from
Jul 19, 2023

Conversation

lpegoraro
Copy link
Contributor

@lpegoraro lpegoraro commented Jul 14, 2023

  • Fixes behavior when Sinks Partial Update was setting the configuration to null in Redis
  • Fixes Delete Event not being read properly due to misconfigured owner id
  • Fixes Sink Status After Partial Update not being Unknown.
  • Add enhanced error messages in Sink.
  • Fixed a wrong validation of custom headers not allowing un-restricted headers

@lpegoraro lpegoraro self-assigned this Jul 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #2501 (fab038e) into develop (82cd9a6) will decrease coverage by 0.02%.
The diff coverage is 37.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #2501      +/-   ##
===========================================
- Coverage    54.86%   54.84%   -0.02%     
===========================================
  Files           74       74              
  Lines         5882     5887       +5     
===========================================
+ Hits          3227     3229       +2     
- Misses        2655     2658       +3     
Impacted Files Coverage Δ
sinker/redis/sinker.go 32.09% <0.00%> (-0.41%) ⬇️
maestro/config/config_builder.go 63.33% <50.00%> (-0.96%) ⬇️
sinks/sinks_service.go 60.21% <50.00%> (-0.08%) ⬇️

@lpegoraro lpegoraro marked this pull request as ready for review July 17, 2023 13:56
@lpegoraro lpegoraro requested a review from weyrick July 17, 2023 19:21
weyrick
weyrick previously approved these changes Jul 17, 2023
sinker/redis/consumer/streams.go Outdated Show resolved Hide resolved
sinker/redis/consumer/streams.go Outdated Show resolved Hide resolved
@lpegoraro lpegoraro requested a review from weyrick July 18, 2023 12:19
manrodrigues
manrodrigues previously approved these changes Jul 19, 2023
etaques
etaques previously approved these changes Jul 19, 2023
Copy link
Contributor

@etaques etaques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpegoraro lpegoraro dismissed stale reviews from etaques and manrodrigues via 50141d6 July 19, 2023 18:36
@lpegoraro lpegoraro merged commit 871fa3b into orb-community:develop Jul 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants