OCI Connection String Provider #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
fmeheust
reviewed
Nov 20, 2024
|
|
||
| String alias; | ||
| try { | ||
| alias = parseParameterValues(parameterValues).getRequired(TNS_ALIAS); |
There was a problem hiding this comment.
Shouldn't you check if the parameter is present sooner, so that it if parameter is missing you can fail faster, before getting the secret from OCI and parsing the file?
fmeheust
reviewed
Nov 20, 2024
ojdbc-provider-oci/README.md
Outdated
|
|
||
| This enables flexible and secure configuration for database connections using the alias names defined in your `tnsnames.ora` file. | ||
|
|
||
| In addition to the set of common parameters, this provider also supports the parameters listed below: |
There was a problem hiding this comment.
Does it support or require the parameters listed below?
…nd clarify required parameters in documentation
fmeheust
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for storing and retrieving
tnsnames.orafiles in Oracle Cloud Infrastructure (OCI) Vault, allowing Oracle JDBC users to securely configure connection strings based on specified aliases. This enhancement brings secure and flexible connection configuration capabilities to OCI environments, ensuring consistency with features available on other cloud platforms (GCP and Azure).issue: #120