Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10950] refactor ODP implementation #973

Merged
merged 28 commits into from
Dec 12, 2024
Merged

[FSSDK-10950] refactor ODP implementation #973

merged 28 commits into from
Dec 12, 2024

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Dec 6, 2024 •
edited
Loading

Summary

  • Refactored odp implementaion

Test plan

Issues

  • FSSDK-10950

@raju-opti raju-opti requested a review from a team as a code owner December 6, 2024 13:54
@raju-opti raju-opti marked this pull request as draft December 6, 2024 13:54
@coveralls
Copy link

coveralls commented Dec 9, 2024 •
edited
Loading

Coverage Status

coverage: 83.983% (-3.1%) from 87.059%
when pulling 57a74f0 on raju/odp-refactor
into faee6c7 on master.

@raju-opti raju-opti changed the title Raju/odp refactor [FSSDK-10950] refactor ODP implementation Dec 9, 2024
@raju-opti raju-opti marked this pull request as ready for review December 9, 2024 18:54
junaed-optimizely
junaed-optimizely approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@junaed-optimizely junaed-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

All most all of the issues are regarding copyright text, and some minor cleanups!

lib/index.browser.tests.js Outdated Show resolved Hide resolved
lib/odp/constant.ts Outdated Show resolved Hide resolved
lib/odp/odp_manager_factory.browser.spec.ts Outdated Show resolved Hide resolved
lib/odp/odp_manager_factory.browser.ts Outdated Show resolved Hide resolved
lib/odp/odp_manager_factory.node.spec.ts Outdated Show resolved Hide resolved
lib/vuid/vuid_manager.spec.ts Outdated Show resolved Hide resolved
lib/vuid/vuid_manager_factory.browser.spec.ts Show resolved Hide resolved
lib/vuid/vuid_manager_factory.node.spec.ts Outdated Show resolved Hide resolved
lib/vuid/vuid_manager_factory.ts Outdated Show resolved Hide resolved
lib/odp/event_manager/odp_event_api_manager.spec.ts Outdated Show resolved Hide resolved
@raju-opti raju-opti merged commit e0aabf5 into master Dec 12, 2024
11 of 19 checks passed
@raju-opti raju-opti deleted the raju/odp-refactor branch December 12, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junaed-optimizely junaed-optimizely junaed-optimizely approved these changes

Assignees

@raju-opti raju-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raju-opti @coveralls @junaed-optimizely