Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8584] chore: prepare for release v2.0.0 #386

Merged
merged 5 commits into from
Jan 19, 2024
Merged

[FSSDK-8584] chore: prepare for release v2.0.0 #386

merged 5 commits into from
Jan 19, 2024

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Jan 18, 2024 •
edited
Loading

Summary

  • updated changelog
  • updated LICENSE file year
  • updated readme
  • updated module path as per convention. [Ref]

Ticket

@pulak-opti pulak-opti force-pushed the pulak/prepare-release-2.0 branch from f7a8ea1 to 19b4c18 Compare January 18, 2024 14:58
@pulak-opti pulak-opti force-pushed the pulak/prepare-release-2.0 branch from 35433e9 to fab2857 Compare January 18, 2024 18:47
@pulak-opti pulak-opti marked this pull request as ready for review January 18, 2024 18:53
@pulak-opti pulak-opti requested a review from a team as a code owner January 18, 2024 18:53
mikechu-optimizely
mikechu-optimizely requested changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change to the copyright needed, but otherwise, LGTM

LICENSE Outdated Show resolved Hide resolved
examples/benchmark/main.go Show resolved Hide resolved
jaeopt
jaeopt requested changes Jan 18, 2024
View reviewed changes
Copy link

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright needs be changed. A clarification regarding /v2.

LICENSE Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@pulak-opti @mikechu-optimizely
Update LICENSE
047037e 
Co-authored-by: Mike Chu <[email protected]>
mikechu-optimizely
mikechu-optimizely approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 19, 2024
View reviewed changes
Copy link

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulak-opti pulak-opti merged commit 26cf04d into master Jan 19, 2024
12 of 14 checks passed
@pulak-opti pulak-opti deleted the pulak/prepare-release-2.0 branch January 19, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees

@pulak-opti pulak-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulak-opti @jaeopt @mikechu-optimizely