Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9774] chore: convert warning into error log for SyncConfig failure #383

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

pulak-opti
Copy link
Contributor

Summary

  • improved error logging for sync config failure. Raised here

Ticket

@pulak-opti pulak-opti marked this pull request as ready for review November 21, 2023 12:41
@pulak-opti pulak-opti requested a review from a team as a code owner November 21, 2023 12:41
@pulak-opti pulak-opti changed the title [FSSDK-9774] chore: covert warning into error log for SyncConfig failure [FSSDK-9774] chore: convert warning into error log for SyncConfig failure Nov 21, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

@pulak-opti pulak-opti merged commit c270819 into master Nov 21, 2023
11 checks passed
@pulak-opti pulak-opti deleted the pulak/improve-logging branch November 21, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants