[FSSDK-10505] chore: update mockito and java version #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- java version update to 17
muzahidul-opti
changed the title
raju-opti
approved these changes
Dec 30, 2024
...dler/src/androidTest/java/com/optimizely/ab/android/datafile_handler/DatafileWorkerTest.java
Outdated
Show resolved
Hide resolved
| @@ -76,7 +76,8 @@ ext { | |||
| jacksonversion= "2.11.2" | |||
| annotations_ver = "1.2.0" | |||
| junit_ver = "4.12" | |||
| mockito_ver = "1.10.19" | |||
| mockito_ver = "4.11.0" | |||
| mockito_ver_sdk_module = "3.6.28" | |||
There was a problem hiding this comment.
curious, why are we using different version for this?
There was a problem hiding this comment.
Android sdk module uses PowerMock which is built based on Mockito Core. The last supported version of PowerMock is Mockito 3.6.28.
| return null; | ||
| } | ||
| }).when(manager.getDatafileHandler()).downloadDatafile(any(Context.class), any(DatafileConfig.class), any(DatafileLoadedListener.class)); | ||
| ArgumentCaptor<Context> contextCaptor = ArgumentCaptor.forClass(Context.class); |
There was a problem hiding this comment.
Looks like the same setup is done in many places. Would it be good to move that out to a separate private method?
There was a problem hiding this comment.
My focus was to update the gradle and java version. We can make the improvement in another PR.
| assertEquals(data.getString("url"), host); | ||
| assertEquals(data.getString("body"), smallBody); | ||
| assertNull(data.getByteArray("bodyCompressed")); | ||
| Data data = EventWorker.compressEvent(host, smallBody); |
There was a problem hiding this comment.
NIT: should be indented two spaces less
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Issues