Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10734] update regex to allow = character #426

Merged
merged 5 commits into from
Oct 4, 2024
Merged

[FSSDK-10734] update regex to allow = character #426

merged 5 commits into from
Oct 4, 2024

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Oct 3, 2024 •
edited
Loading

Summary

  • updated config.yaml
  • updated regex to allow = character

Issues

@pulak-opti pulak-opti changed the title [] add doc in config.yaml for secure env datafileURL template [FSSDK-10734] add doc in config.yaml for secure env datafileURL template Oct 3, 2024
@pulak-opti pulak-opti requested a review from Mat001 October 3, 2024 17:40
@pulak-opti pulak-opti requested a review from jaeopt October 4, 2024 07:52
@pulak-opti pulak-opti changed the title [FSSDK-10734] add doc in config.yaml for secure env datafileURL template [FSSDK-10734] update regex to allow = character Oct 4, 2024
mikechu-optimizely
mikechu-optimizely approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I like your use of character classes. I would have used grouping with the OR ^(\\w|=)+(:(\\w|=)+)?$ but I'm a regex newbie :-)

Mat001
Mat001 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pulak-opti pulak-opti merged commit e80529d into master Oct 4, 2024
13 checks passed
@pulak-opti pulak-opti deleted the pulak/update-datafile-doc branch October 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@Mat001 Mat001 Mat001 approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulak-opti @Mat001 @mikechu-optimizely