Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-8823] chore: prepare for release 4.0.0 #411

Merged
merged 6 commits into from
Jan 22, 2024
Merged

[FSSDK-8823] chore: prepare for release 4.0.0 #411

merged 6 commits into from
Jan 22, 2024

Conversation

pulak-opti
Copy link
Contributor

@pulak-opti pulak-opti commented Jan 19, 2024 •
edited
Loading

Summary

  • prepare for release 4.0.0
  • use go-sdk v2

Issues

@pulak-opti pulak-opti marked this pull request as ready for review January 19, 2024 19:10
mikechu-optimizely
mikechu-optimizely approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Do we need to update the paths in the Makefile?

jaeopt
jaeopt requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A suggestion for CHANGELOG.

CHANGELOG.md Show resolved Hide resolved
@pulak-opti
Copy link
Contributor Author

LGTM, but Do we need to update the paths in the Makefile?

Yes, good catch, thanks

@pulak-opti pulak-opti requested a review from jaeopt January 22, 2024 12:19
mikechu-optimizely
mikechu-optimizely approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jaeopt
jaeopt approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulak-opti pulak-opti merged commit c563262 into master Jan 22, 2024
13 checks passed
@pulak-opti pulak-opti deleted the pulak/prepare-release-4.0 branch January 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

@jaeopt jaeopt jaeopt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pulak-opti @jaeopt @mikechu-optimizely