Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] 🌱 cleanup/registry #3323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

perdasilva
Copy link
Collaborator

@perdasilva perdasilva commented Jun 19, 2024

Description of the change:

  • updates our fixture catalogs to decl config
  • updates the kind provisioning process to stand-up with a local registry
  • adds script to build fixture catalogs (against a fixed/versioned opm image - taking it from )
  • adds/refactors command line parameters of the e2e binary to allow the cluster-registry domain to be configurable
  • updates relevant e2e specs to the updated references
  • updates gha e2e to

NOTE: we'll need to update the downstream to push the internal ocp registry and make sure the e2e binary is configured to use it.

Motivation for the change:
Catalog Source images cannot be kind loaded because the Pod is set to Always pull
We wanted to avoid using, e.g. quay. Though, the bundle images are still stored there. And there are still some specific catalog images being used that have been built long ago and live permanently on quay. If we want to target that, that will be a longer story.

Architectural changes:
Before: we stood up a stock kind cluster
Now: We stand-up a local registry side-by-side with kind (largely following their documentation: https://kind.sigs.k8s.io/docs/user/local-registry/).

Related to #3315

Testing remarks:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Bug fixes are accompanied by regression test(s)
  • e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
  • tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
  • Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
  • Docs updated or added to /doc
  • Commit messages sensible and descriptive
  • Tests marked as [FLAKE] are truly flaky and have an issue
  • Code is properly formatted

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2024
@openshift-ci openshift-ci bot requested review from benluddy and gallettilance June 19, 2024 18:10
@perdasilva perdasilva force-pushed the cleanup/registry branch 7 times, most recently from 17da4ed to fbc4418 Compare June 20, 2024 10:17
@perdasilva perdasilva changed the title [WIP] Cleanup/registry cleanup/registry Jun 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2024
@perdasilva perdasilva changed the title cleanup/registry 🌱 cleanup/registry Jun 20, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a sanity check, this works consistently on both Mac and Linux boxes for standing up a local registry?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I don't have a Mac 😬 - works on linux XD
Would you mind giving it a spin?

make e2e-build kind-create load-test-images deploy e2e

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

borrowed a mac (M1) can confirm deployment works and e2e runs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I found an issue I missed (making sure the kind cluster uses the right node image) - addressed

@perdasilva perdasilva force-pushed the cleanup/registry branch 7 times, most recently from 45be2e7 to 7df68ff Compare June 26, 2024 15:40
Per Goncalves da Silva added 2 commits June 27, 2024 08:08
@perdasilva perdasilva changed the title 🌱 cleanup/registry [HOLD] 🌱 cleanup/registry Jun 27, 2024
@perdasilva
Copy link
Collaborator Author

Let's hold off on merging until we have the downstream sorted - or at least until Monday

Per Goncalves da Silva added 2 commits July 1, 2024 16:26
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants