-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] 🌱 cleanup/registry #3323
base: master
Are you sure you want to change the base?
Conversation
17da4ed
to
fbc4418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a sanity check, this works consistently on both Mac and Linux boxes for standing up a local registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. I don't have a Mac 😬 - works on linux XD
Would you mind giving it a spin?
make e2e-build kind-create load-test-images deploy e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
borrowed a mac (M1) can confirm deployment works and e2e runs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but I found an issue I missed (making sure the kind cluster uses the right node image) - addressed
45be2e7
to
7df68ff
Compare
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
7df68ff
to
2ecbf6c
Compare
Let's hold off on merging until we have the downstream sorted - or at least until Monday |
Signed-off-by: Per Goncalves da Silva <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
2ecbf6c
to
7aede27
Compare
Description of the change:
NOTE: we'll need to update the downstream to push the internal ocp registry and make sure the e2e binary is configured to use it.
Motivation for the change:
Catalog Source images cannot be kind loaded because the Pod is set to Always pull
We wanted to avoid using, e.g. quay. Though, the bundle images are still stored there. And there are still some specific catalog images being used that have been built long ago and live permanently on quay. If we want to target that, that will be a longer story.
Architectural changes:
Before: we stood up a stock kind cluster
Now: We stand-up a local registry side-by-side with kind (largely following their documentation: https://kind.sigs.k8s.io/docs/user/local-registry/).
Related to #3315
Testing remarks:
Reviewer Checklist
/doc
[FLAKE]
are truly flaky and have an issue