Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove nil/blank checks for installed bundle labels #1405

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 24, 2024

These checks were only needed for the upgrade-e2e

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

These checks were only needed for the upgrade-e2e

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort requested a review from a team as a code owner October 24, 2024 03:27
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 3d98c5d
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6719be9be059710008d292b2
😎 Deploy Preview https://deploy-preview-1405--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.38%. Comparing base (1cb254c) to head (3d98c5d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   73.43%   73.38%   -0.05%     
==========================================
  Files          42       42              
  Lines        3200     3194       -6     
==========================================
- Hits         2350     2344       -6     
  Misses        663      663              
  Partials      187      187              
Flag Coverage Δ
e2e 54.94% <ø> (-0.09%) ⬇️
unit 53.38% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort tmshort added this pull request to the merge queue Oct 24, 2024
Merged via the queue into operator-framework:main with commit f88400c Oct 24, 2024
17 of 18 checks passed
@tmshort tmshort deleted the remove-blank-checks branch October 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants