-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalization of the update matcher #2014
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d5a5737
feat: create resource only if not exists (#2001)
csviri ffdcc10
feat: leader election callbacks (#2015)
csviri 5c458e5
discriminator improvements (#2013)
csviri 8675f3f
generalization of the update matcher
shawkins 0357ac3
consolidating the diffs
shawkins 4de80dd
Merge branch 'next' into generalized_match
csviri fe720ec
Merge branch 'next' into generalized_match
csviri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
...cessing/dependent/kubernetes/updatermatcher/ClusterRoleBindingResourceUpdaterMatcher.java
This file was deleted.
Oops, something went wrong.
22 changes: 0 additions & 22 deletions
22
...tor/processing/dependent/kubernetes/updatermatcher/ClusterRoleResourceUpdaterMatcher.java
This file was deleted.
Oops, something went wrong.
24 changes: 0 additions & 24 deletions
24
...rator/processing/dependent/kubernetes/updatermatcher/ConfigMapResourceUpdaterMatcher.java
This file was deleted.
Oops, something went wrong.
25 changes: 0 additions & 25 deletions
25
...or/processing/dependent/kubernetes/updatermatcher/EndpointSliceResourceUpdateMatcher.java
This file was deleted.
Oops, something went wrong.
20 changes: 0 additions & 20 deletions
20
...rator/processing/dependent/kubernetes/updatermatcher/EndpointsResourceUpdaterMatcher.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 0 additions & 23 deletions
23
...tor/processing/dependent/kubernetes/updatermatcher/RoleBindingResourceUpdaterMatcher.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this is opening potential issues where the cloning occurs in a different manner than here if, for some reason, the configured resource cloner has a different serialization set up… Should we remove the cloner altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was the only instance of the cloner being used, it could be removed or deprecated. There is also a clone method on KubernetesSerialization.