Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not log sensitive resources #2003

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix: do not log sensitive resources #2003

merged 1 commit into from
Aug 7, 2023

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Aug 7, 2023 •
edited
Loading

see: #1983

@csviri csviri self-assigned this Aug 7, 2023
@metacosm metacosm self-requested a review August 7, 2023 14:46
@metacosm metacosm changed the title fix: logging sensite resources fix: logging sensitive resources Aug 7, 2023
@metacosm metacosm changed the title fix: logging sensitive resources fix: do not log sensitive resources Aug 7, 2023
@csviri csviri merged commit 3b72bb4 into main Aug 7, 2023
17 checks passed
@csviri csviri deleted the not-logging-secret branch August 7, 2023 14:56
@csviri csviri mentioned this pull request Aug 7, 2023
Closed
@shawkins shawkins mentioned this pull request Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

@andreaTP andreaTP Awaiting requested review from andreaTP

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csviri @metacosm