Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ClusterRoleBinding with default namespace ( WebPage sample ) #1991

Merged
merged 1 commit into from
Aug 1, 2023
Merged

feat: update ClusterRoleBinding with default namespace ( WebPage sample ) #1991

merged 1 commit into from
Aug 1, 2023

Conversation

yarinkos
Copy link
Contributor

@yarinkos yarinkos commented Aug 1, 2023

Although operator.yaml is mostly used by the E2E test, it would be nice to have it available for manual tests as well

Manually applying would currently result in the following error:

kubectl apply -f k8s/operator.yaml
serviceaccount/webpage-operator unchanged
..
...
The ClusterRoleBinding "operator-admin" is invalid: subjects[0].namespace: Required value

@csviri csviri self-assigned this Aug 1, 2023
@yarinkos yarinkos changed the title feat: update ClusterRoleBinding with default namespace feat: update ClusterRoleBinding with default namespace ( WebPage sample ) Aug 1, 2023
csviri
csviri approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csviri csviri merged commit 2762f28 into operator-framework:main Aug 1, 2023
17 checks passed
@csviri
Copy link
Collaborator

csviri commented Aug 1, 2023

thank you @yarinkos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

@adam-sandor adam-sandor Awaiting requested review from adam-sandor

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarinkos @csviri