Add extraManifests value #27
Conversation
|
Done with the requested changes |
| @@ -143,3 +143,12 @@ extraServicePorts: [] | |||
|
|
|||
| # global variables to use in values. typically used in tests. | |||
| global: {} | |||
|
|
|||
| # extra manifests to deploy with the helm chart | |||
| extraManifests: [] | |||
There was a problem hiding this comment.
Shouldn't this be extraManifests: {} to match the object type?
There was a problem hiding this comment.
PR welcome and merged quickly to fix any mistakes! One way even more ideal is to add ci tests as we have for some other options, but I'll leave that up to the person to decide to do or not.
There was a problem hiding this comment.
@marcuz no, array is correct. If you want to be more accurate you can change it to be array of objects [ {} ].
There was a problem hiding this comment.
Yeah, the fix in #32 seems to work. 😄
There was a problem hiding this comment.
thanks @marcuz and @CiucurDaniel. If either of you have time to add a fake value in a ci file, please do, so that the mystery stays solved https://github.com/openzipkin/zipkin-helm/tree/master/charts/zipkin/ci
that or add the linting not currently happening to our workflow config
https://github.com/openzipkin/zipkin-helm/blob/master/.github/workflows/test.yml#L72
This PR implements #26