Skip to content

Commit

Permalink
Change secret for wheel publishing (#1955)
Browse files Browse the repository at this point in the history
The workflow GitHub App default credential in OpenXLA cannot create
GitHub releases.

Follow the convention identified by IREE in OpenXLA which uses a
[repository
secret](https://github.com/openxla/iree/blob/79b6129e2333ae26e7e13b68c27566102dcece6e/.github/workflows/validate_and_publish_release.yml#L112C37-L112C55)
linked to a developers credential with repo permissions.

The secret created here was created by gleasonk@ and the secret at the
moment of this commit belongs to fzakaria@.
It is valid for 1-year.
  • Loading branch information
fzakaria authored Jan 26, 2024
1 parent a404438 commit d4cb569
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/publishWheelRelease.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ jobs:
uses: ncipollo/[email protected]
with:
artifacts: "${{ github.sha }}/*.whl"
token: "${{ secrets.GITHUB_TOKEN }}"
token: "${{ secrets.PUBLISH_ACCESS_TOKEN }}"
# git describe in setup.py explicitly filters out this tag
tag: "dev-wheels"
name: "dev-wheels"
Expand Down

0 comments on commit d4cb569

Please sign in to comment.