Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baresip,libre: Update to version 3.16.0 #885

Closed
wants to merge 3 commits into from

Conversation

dddaniel
Copy link

@dddaniel dddaniel commented Nov 6, 2024

The previous version 1.1.0 is about 7 years old now and a lot has changed. Various fixes, improvements and features have been added.

The build system has moved to cmake and pkg-config is used, which makes it a lot easier to build from the openwrt buildroot. Therefore a lot of the extra code is removed from the makefiles.

librem is now integrated into libre.

No more patches are required.

@jslachta
Copy link
Contributor

jslachta commented Nov 6, 2024

Hello Daniel (@dddaniel),

given our limited maintainer capacity, could you at least provide information on the run-tests and confirm whether Baresip can still run after your changes? Just a formal check.

Kind regards,
Jiri

@dddaniel
Copy link
Author

dddaniel commented Nov 7, 2024

Hi @jslachta, I ran a couple of x86 builds with all plugins enabled. Besides that I am actively using it.

There will be a couple follow up PR's regarding the init script that isn't running in it's current form.
(Also in the previous version, because of a missing user)
In addition I would like to add UCI support for it. The current /etc/default/baresip doesn't integrate well into openwrt.

Copy link
Contributor

@jslachta jslachta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, please take a look at the PKG_RELEASE variables that should reset to 1 after PKG_VERSION change.

Also it would be useful to split the changes into two commits, first libre, then baresip, to keep the history cleaner.

libs/re/Makefile Outdated Show resolved Hide resolved
@jslachta
Copy link
Contributor

jslachta commented Nov 8, 2024

Thank you, Daniel (@dddaniel ). Your PR looks ready to merge. It looks like the test builds are currently broken. I'll check them first and then rerun. If the build succeeds, I’ll proceed with merging your PR.

@Ansuel
Copy link
Member

Ansuel commented Nov 8, 2024

@dddaniel can you rebase this on top of master?

@jslachta
Copy link
Contributor

jslachta commented Nov 8, 2024

Thank you, Christian (@Ansuel), for updating the GitHub workflow.

Daniel Danzberger added 3 commits November 9, 2024 13:08
The previous version 2.0.1 is about 7 years old now and a lot has
changed. Various fixes, improvements and features have been added.

The build system has moved to cmake and pkg-config is used,
which makes it a lot easier to build from the openwrt buildroot.
Therefore a lot of the extra code is removed from it's Makefile

Librem is now integrated into libre.
No more patches are required.

Signed-off-by: Daniel Danzberger <[email protected]>
The previous version 1.1.0 is about 7 years old now and a lot has
changed. Various fixes, improvements and features have been added.

The build system has moved to cmake and pkg-config is used,
which makes it a lot easier to build from the openwrt buildroot.
Therefore a lot of the extra code is removed from it's Makefile.

The librem dependency has been removed, since newer versions of libre
contain all the librem features.

The parallel build patch is no longer required.

Signed-off-by: Daniel Danzberger <[email protected]>
All librem features are now part of libre and the only package that
depended on it (baresip) now uses libre.

It can therefore be removed.

Signed-off-by: Daniel Danzberger <[email protected]>
@dddaniel
Copy link
Author

dddaniel commented Nov 9, 2024

Hi @jslachta, I just found out during testing that some of the old plugins have been moved to a new repo called baresip-apps.
In order to have all the features available with this update, there needs to be a new package added. So I will close this PR for now and create a new one when it's done.

@dddaniel dddaniel closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants