luci-base: add member duplicate to DynamicList
#7558
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add member `duplicate` to `DynamicList` to allow duplicate underlying form values. `duplicate` defaults is `null`, `DynamicList` will keep the same behavior as before. If `true`, the underlying form value will not be checked for duplication. Signed-off-by: Anya Lin <[email protected]>
Ramon00
reviewed
Jan 11, 2025
| @@ -2505,7 +2505,8 @@ const UIDynamicList = UIElement.extend(/** @lends LuCI.ui.DynamicList.prototype | |||
| return; | |||
|
|
|||
| sbIn.setValues(sbEl, null); | |||
| sbVal.element.setAttribute('unselectable', ''); | |||
| if (!this.options.duplicate) | |||
| sbVal.element.setAttribute('unselectable', ''); | |||
There was a problem hiding this comment.
Why is there a need for a dependency of "unselectable" on "duplicate"?
There was a problem hiding this comment.
Because we can add preset chooses to DynamicList through o.value(key, label).
And the selected key choose will become unselectable.
This will prevent us from adding the same key.
There was a problem hiding this comment.
ah right, just from the name I was thinking it had to do with the ability to select the text, e.g. for copy/paste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the MakefileDescription:
Add member
duplicatetoDynamicListto allow duplicate underlying form values.duplicatedefaults isnull,DynamicListwill keep the same behavior as before.If
o.duplicate = true, the underlying form value will not be checked for duplication.Screenshot: