luci-mod-dashboard: make the DHCP Devices and Wireless proper tables with headers. #7550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemcrash
reviewed
Jan 10, 2025
modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js
Show resolved
Hide resolved
systemcrash
reviewed
Jan 10, 2025
modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/20_lan.js
Show resolved
Hide resolved
systemcrash
reviewed
Jan 10, 2025
modules/luci-mod-dashboard/htdocs/luci-static/resources/view/dashboard/include/30_wifi.js
Show resolved
Hide resolved
|
OK. Please squash your commits. |
…with headers. Also, the Lan and WiFi tables are half-width, we should not use the table-titles which has @media rules about 992px. Signed-off-by: Jan Pazdziora <[email protected]>
|
Squashed, rebased on master. |
|
Merged. Thanks @adelton |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile<hr/>s that can be done with CSS, create baseline for proper CSS styling.