luci-app-firewall: remove zone name length limitiation

[evlli]

It was already possible to exceed the 11 character limit by creating the new zone in the interface edit view. #6008
I could not find a test case where a longer name causes functional problems, therefor this patch removes the limit in the firewall view as well, in order to allow for more descriptive zone names.

Signed-off-by: Evelyn Alicke [email protected]

[jow-]

This change is only legal for firewall4, the iptables based firewall3 still has a length limitation.

[systemcrash]

@evlli So one way one could get around this is by putting a firewall version check in the JS. And having the length check still apply if fw version == 3. Not sure how to handle the htm tho. Do you have any suggestions?

[evlli]

@systemcrash I've thought about this a few times and I'm honestly not very familiar with the codebase. I guess replacing the htm check with more js is the only way? that feels like a much bigger change than I originally planned for but I'm fine with it.

[systemcrash]

The JS part seems trivial enough. But the HTML part, I guess we can drop? All new stuff is JS only, though this does not say what we must do with the Lua only parts. @jow- ?

If you think you can crack the HTML part also, give it a go!