Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Allowed deleting device with "deactivating" config status #949 #962

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jan 2, 2025

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Fixes #949

Blockers

  • Add more selenium tests
  • Handle deleting multiple deactivating device
device-deletion-2025-01-02_22.31.03.mp4

@pandafy pandafy marked this pull request as draft January 2, 2025 17:18
@pandafy pandafy force-pushed the issues/949-delete-offline-devices branch from 13e94a6 to 9960afc Compare January 6, 2025 16:20
@pandafy pandafy marked this pull request as ready for review January 6, 2025 16:21
@pandafy pandafy force-pushed the issues/949-delete-offline-devices branch from e50f5fd to f8b3b9f Compare January 7, 2025 09:03
@pandafy pandafy force-pushed the issues/949-delete-offline-devices branch from f8b3b9f to e182b17 Compare January 7, 2025 09:09
@coveralls
Copy link

Coverage Status

coverage: 98.078% (-0.2%) from 98.261%
when pulling 53dbb32 on issues/949-delete-offline-devices
into 98fd7b1 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Unable to delete offline device
2 participants