feat: dcql alpha #2098
Draft
feat: dcql alpha #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af89f1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Martin Auer <[email protected]>
TimoGlastra
approved these changes
Nov 21, 2024
| for (const credentialQueryId of firstFullFillableOption) { | ||
| const credential = dcqlQueryResult.credential_matches[credentialQueryId] | ||
|
|
||
| if (credential.success && credential.record.type === 'MdocRecord' && 'namespaces' in credential.output) { |
There was a problem hiding this comment.
I usually prefer adding a diferentiator key that then also defiens the type of credential.
So credential has a format key and if it is mso_mdoc then output has namespaces.
| } | ||
|
|
||
| // TODO: this IS WRONG | ||
| private createPresentationFrame(obj: Record<string, JsonValue>): IPresentationFrame { |
There was a problem hiding this comment.
Yes for SdJwt presentations. Will fix it in the weekend
packages/openid4vc/src/openid4vc-holder/OpenId4vcSiopHolderService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-holder/OpenId4vcSiopHolderService.ts
Outdated
Show resolved
Hide resolved
packages/openid4vc/src/openid4vc-verifier/OpenId4VcSiopVerifierService.ts
Outdated
Show resolved
Hide resolved
…ax for oid4vp Signed-off-by: Timo Glastra <[email protected]>
…se` and `SdJwtVc` to allow for easier type narrowing Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Martin Auer <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
reviewed
Nov 25, 2024
| if (result.success) { | ||
| if (result.output.credential_format === 'vc+sd-jwt') { | ||
| const sdJwtVcRecord = credentialRecords[result.input_credential_index] as SdJwtVcRecord | ||
| agentContext.dependencyManager |
There was a problem hiding this comment.
The return value of this call is not used
TimoGlastra
reviewed
Nov 26, 2024
Comment on lines
116
to
128
| const transformValue = (value: unknown): unknown => { | ||
| if (typeof value !== 'function' && typeof value !== 'object') return value | ||
| return isToJsonable(value) ? value.toJson() : 'unknown json representation' | ||
| } | ||
|
|
||
| const mdoc = Mdoc.fromBase64Url(record.base64Url) | ||
|
|
||
| const namespaces = Object.fromEntries( | ||
| Object.entries(mdoc.issuerSignedNamespaces).map(([key, namespace]) => [ | ||
| key, | ||
| Object.fromEntries(Object.entries(namespace).map(([k, v]) => [k, transformValue(v)])), | ||
| ]) | ||
| ) |
There was a problem hiding this comment.
here you still convert to json? shouldn't this be handled by dcql?
TimoGlastra
reviewed
Nov 26, 2024
Comment on lines
153
to
163
| const claims = agentContext.dependencyManager | ||
| .resolve(SdJwtVcService) | ||
| .applyDisclosuresForPayload(sdJwtVcRecord.compactSdJwtVc, result.output.claims) | ||
| return [ | ||
| credential_query_id, | ||
| { | ||
| ...result, | ||
| output: { ...result.output, claims }, | ||
| record: credentialRecords[result.input_credential_index], | ||
| }, | ||
| ] |
There was a problem hiding this comment.
This returns the whole sd jwt vc. not the claims.
So should do claims.prettyClaims
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.